Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proper handling of complex numbers and failures #265

Merged
merged 28 commits into from
Nov 1, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Oct 27, 2023

Fixes #269

  • __findmin ignores NaNs
  • TR returns ConvergenceFailure if it stops due to shrinking
  • complex numbers gave a complex abstol/reltol
  • TR solves an ill conditioned GN step which is not needed.
  • Test for an infeasible case!
  • Reworks the Termination Conditions and makes everything type stable (if chunksize and such are specified)!
  • Return Codes are more meaningful

TODO

@avik-pal avik-pal force-pushed the ap/fixes branch 2 times, most recently from 2d4a88d to 19fb541 Compare October 27, 2023 16:54
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #265 (c489b23) into master (1e4c3c0) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master    #265   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          19      19           
  Lines        1744    1754   +10     
======================================
- Misses       1744    1754   +10     
Files Coverage Δ
ext/NonlinearSolveFastLevenbergMarquardtExt.jl 0.00% <ø> (ø)
ext/NonlinearSolveLeastSquaresOptimExt.jl 0.00% <ø> (ø)
src/ad.jl 0.00% <ø> (ø)
src/extension_algs.jl 0.00% <ø> (ø)
src/jacobian.jl 0.00% <0.00%> (ø)
src/default.jl 0.00% <0.00%> (ø)
src/NonlinearSolve.jl 0.00% <0.00%> (ø)
src/raphson.jl 0.00% <0.00%> (ø)
src/pseudotransient.jl 0.00% <0.00%> (ø)
src/levenberg.jl 0.00% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avik-pal avik-pal changed the title Proper handling of complex numbers and failures [WIP] Proper handling of complex numbers and failures Oct 28, 2023
@avik-pal avik-pal force-pushed the ap/fixes branch 2 times, most recently from b110e05 to a3c8951 Compare October 29, 2023 13:48
@avik-pal
Copy link
Member Author

@avik-pal avik-pal changed the title [WIP] Proper handling of complex numbers and failures Proper handling of complex numbers and failures Nov 1, 2023
@avik-pal
Copy link
Member Author

avik-pal commented Nov 1, 2023

@ChrisRackauckas this should be good to go

@ChrisRackauckas ChrisRackauckas merged commit 52b421e into SciML:master Nov 1, 2023
@avik-pal avik-pal deleted the ap/fixes branch November 1, 2023 20:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants