Skip to content

Minor Fixes #308

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Minor Fixes #308

merged 2 commits into from
Dec 9, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 8, 2023

Checklist

  • MINPACK and NLsolve throw error if termination_condition is specified
  • MINPACK says converged even if it didn't. Override its result with a manual check
  • LM missed a sqrt for the standard LS form

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cbf0861) 89.35% compared to head (41f4fec) 80.47%.

Files Patch % Lines
src/levenberg.jl 76.19% 5 Missing ⚠️
ext/NonlinearSolveMINPACKExt.jl 0.00% 3 Missing ⚠️
ext/NonlinearSolveNLsolveExt.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   89.35%   80.47%   -8.89%     
==========================================
  Files          23       23              
  Lines        1936     1936              
==========================================
- Hits         1730     1558     -172     
- Misses        206      378     +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal force-pushed the ap/minor_patches branch 6 times, most recently from 384c663 to af5db27 Compare December 8, 2023 18:19
@avik-pal avik-pal closed this Dec 8, 2023
@avik-pal avik-pal reopened this Dec 8, 2023
@avik-pal avik-pal merged commit b0c28f1 into SciML:master Dec 9, 2023
@avik-pal avik-pal deleted the ap/minor_patches branch December 9, 2023 02:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant