make RobustMultiNewton always respect autodiff choice #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 88.06% 83.79% -4.27%
==========================================
Files 28 28
Lines 2178 2179 +1
==========================================
- Hits 1918 1826 -92
- Misses 260 353 +93 ☔ View full report in Codecov by Sentry. |
avik-pal
approved these changes
Jan 5, 2024
|
@oscardssmith can you rerun the formatter once? |
ChrisRackauckas
approved these changes
Jan 5, 2024
|
And add a test |
|
Formatted and tests added. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably needs a test, but the TLDR is that it fixes use of
RobustMultiNewtonwith autodiff incompatible functions. BeforeTrustRegion(; concrete_jac, linsolve, precs)would mean that it would throw duals at the problem even if you specifiedautodiff=AutoFiniteDiff()