Skip to content

pass in linesearch #400

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

pass in linesearch #400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ce1021
pass in linesearch
avik-pal Apr 2, 2024
2a35fe4
Update Project.toml
avik-pal Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NonlinearSolve"
uuid = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
authors = ["SciML"]
version = "3.9.0"
version = "3.9.1"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
2 changes: 1 addition & 1 deletion src/algorithms/gauss_newton.jl
View file
Original file line number Diff line number Diff line change
@@ -10,5 +10,5 @@ function GaussNewton(; concrete_jac = nothing, linsolve = nothing, precs = DEFAU
linesearch = NoLineSearch(), vjp_autodiff = nothing, autodiff = nothing)
descent = NewtonDescent(; linsolve, precs)
return GeneralizedFirstOrderAlgorithm(; concrete_jac, name = :GaussNewton, descent,
jacobian_ad = autodiff, reverse_ad = vjp_autodiff)
jacobian_ad = autodiff, reverse_ad = vjp_autodiff, linesearch)
end
Loading