Skip to content

feat: support indexing AbstractNonlinearSolveCache #406

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

AayushSabharwal
Copy link
Member

Close SciML/SciMLBase.jl#662

@TorkelE

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (e3238a7) to head (b70fbe1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   86.59%   80.14%   -6.46%     
==========================================
  Files          46       46              
  Lines        2827     2840      +13     
==========================================
- Hits         2448     2276     -172     
- Misses        379      564     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal force-pushed the as/nlintegrator-indexing branch from f2b02b1 to b70fbe1 Compare April 15, 2024 08:12
@ChrisRackauckas ChrisRackauckas merged commit b2f9c51 into SciML:master Apr 15, 2024
10 of 15 checks passed
@AayushSabharwal AayushSabharwal deleted the as/nlintegrator-indexing branch April 15, 2024 10:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbolic indexing fails for Nonlinear problem integrators
2 participants