feat: add SciMLJacobianOperators package
#460
Merged
+1,075
−425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/jacop
branch
2 times, most recently
from
a2cf27e to
1a8cd78
Compare
|
@ChrisRackauckas I am spinning out the jacobian operator out of NonlinearSolve. Need to use it for LineSearch. It also provides a solution to the long standing vjp/jvp interface for SciMLOperators |
avik-pal
force-pushed
the
ap/jacop
branch
2 times, most recently
from
cc93129 to
37c56f7
Compare
avik-pal
force-pushed
the
ap/jacop
branch
4 times, most recently
from
243658e to
36b70c8
Compare
|
should WOperator also be split out? |
This particular split is to avoid a circular dep issue between LineSearch and NonlinearSolve. |
|
ILU is broken (segfaults) even on master. Skipping that to get the build passing |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everyone knows how bad SciMLOperators function operator is (and I really want to avoid touching that package). This pulls out the JacobianOperator and related functionality from NonlinearSolve.jl so that I can use in SimpleNonlinearSolve and LineSearch
fixes #442
TODOs