Skip to content

use LinearSolve precs setup #462

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

oscardssmith
Copy link
Member

This updates NonlinearSolve to use the new precs interface in LinearSolve.

@avik-pal
Copy link
Member

This would require a major version bump.

@mpf
Copy link

mpf commented Sep 25, 2024

See also this Julia Discourse post.

@ChrisRackauckas
Copy link
Member

Is this needed?

@oscardssmith
Copy link
Member Author

it's not needed, but will be nice (as it will bring the interface inline with LinearSolve and OrdinaryDiffEq@V7

@ChrisRackauckas
Copy link
Member

okay, I thought it was covered by another PR already.

@oscardssmith
Copy link
Member Author

#465 was a simpler fix that fixed the bug that led me to create this PR, but all that did was switch NonlinearSolve from a cursed diagonal preconditioner to a real diagonal preconditioner, whereas this PR removes the preconditioner from the NonlinearSolve side entirely since the LinearSolve side can do all the work.

@oscardssmith
Copy link
Member Author

@avik-pal if I rebase this, do you think we're ready to do the version bump required? I think this is a good change, but I don't really want to go through the rebase until you think we're conceptually ready to merge.

@avik-pal
Copy link
Member

not yet, we need #458 to be merged before doing a bump

@avik-pal avik-pal mentioned this pull request Oct 22, 2024
12 tasks
@avik-pal
Copy link
Member

@oscardssmith we can get this in now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants