Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Equality checks with nothing #587

Merged
merged 2 commits into from
Jan 5, 2019
Merged

Equality checks with nothing #587

merged 2 commits into from
Jan 5, 2019

Conversation

devmotion
Copy link
Member

This is only a cosmetic change (as far as I can see) since we dispatch on the types of the checked variables and hence all checks should be compiled away, but apparently using === nothing instead of == nothing can be slightly more performant (see JuliaLang/julia#29674 (comment)) and it doesn't hurt to use === consistently. Additionally, === always returns a Bool whereas e.g. missing == nothing evaluates to missing.

@coveralls
Copy link

coveralls commented Jan 4, 2019

Coverage Status

Coverage increased (+6.9%) to 53.208% when pulling 1de500a on nothing_equality into 90c47b6 on master.

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is 23.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files          82       82           
  Lines       24069    24069           
=======================================
  Hits        16338    16338           
  Misses       7731     7731
Impacted Files Coverage Δ
src/integrators/integrator_utils.jl 71.09% <0%> (ø) ⬆️
src/integrators/integrator_interface.jl 74.78% <0%> (ø) ⬆️
src/dense/generic_dense.jl 70.37% <0%> (ø) ⬆️
src/derivative_utils.jl 69.12% <100%> (ø) ⬆️
src/solve.jl 73.73% <44.44%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c47b6...1de500a. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants