Skip to content

Make Function Operator Type Stable #225

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 5, 2023

Branched off #224

Some of the traits needed to be hoisted from the traits NamedTuple to the type.

xref: JuliaDiff/SparseDiffTools.jl#272 (comment)

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #225 (ec73bd2) into master (451c583) will increase coverage by 0.07%.
The diff coverage is 88.67%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   69.65%   69.73%   +0.07%     
==========================================
  Files          10       10              
  Lines        1618     1642      +24     
==========================================
+ Hits         1127     1145      +18     
- Misses        491      497       +6     
Files Coverage Δ
src/basic.jl 70.96% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)
src/func.jl 83.10% <88.23%> (-0.84%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ChrisRackauckas
Copy link
Member

test failure looks real.

@avik-pal avik-pal merged commit f86a556 into SciML:master Nov 5, 2023
@avik-pal avik-pal deleted the ap/tstable_func branch November 5, 2023 22:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants