Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rebuild content #183

Merged
merged 9 commits into from
Jun 24, 2020
Merged

Rebuild content #183

merged 9 commits into from
Jun 24, 2020

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@christopher-dG
Copy link
Contributor

03-optimizing_diffeq_code.jmd is missing here, it seems that it ran out of memory or something: https://gitlab.com/JuliaGPU/DiffEqTutorials.jl/-/jobs/608487965#L1319

@ChrisRackauckas
Copy link
Member

It looks like the project.tomls need DiffEqTutorials in there for the footers.

@@ -671,35 +682,16 @@ saved_values.saveval

Go back to the Harmonic oscillator. Use the `SavingCallback` to save an array for the energy over time, and do this both with and without the `ManifoldProjection`. Plot the results to see the difference the projection makes.

````
Error: ArgumentError: Package DiffEqTutorials not found in current path:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, DiffEqTutorials is not in the inner Project.toml. How do we make the environments stack?

@ChrisRackauckas
Copy link
Member

It would be nice to have the netlify setup now, because the pdfs aren't rendered so well... we should get a better PDF template, but that's a long term thing.

@ChrisRackauckas
Copy link
Member

oh viewing the .md files is probably the easiest. duh.

@ChrisRackauckas
Copy link
Member

03-optimizing_diffeq_code.jmd is missing here, it seems that it ran out of memory or something: https://gitlab.com/JuliaGPU/DiffEqTutorials.jl/-/jobs/608487965#L1319

Yeah, that run it failed on is pretty giant. We might need to use the benchmarking server for the tutorials, which is good anyways since a lot of the tutorials go over code optimization so they need stable benchmarking too.

@christopher-dG
Copy link
Contributor

It looks like we can load DiffEqTutorials from the inner environment with pushfirst!(LOAD_PATH, "@.")

@christopher-dG
Copy link
Contributor

christopher-dG commented Jun 23, 2020

!rebuild introduction

oops, i added a check for membership and apparently it's wrong...

@github-actions
Copy link
Contributor Author

You're not allowed to do that.

@ChrisRackauckas
Copy link
Member

You're not allowed to do that.

😆 get told.

@christopher-dG
Copy link
Contributor

!rebuild introduction

it's gonna yell at me again but this time it'll print out some debug info for me 🙃

@github-actions
Copy link
Contributor Author

You're not allowed to do that.

@christopher-dG
Copy link
Contributor

grr, i may have to spam in here more than i would like 😬

@christopher-dG
Copy link
Contributor

christopher-dG commented Jun 23, 2020

Oh... it's a JS thing.

> "foo" in ["foo"]
false

it gets better (I guess it checks index membership?!)

> 1 in ["foo"]
false

> 0 in ["foo"]
true

@ChrisRackauckas
Copy link
Member

wat

@christopher-dG
Copy link
Contributor

I guess it kind of makes sense when you look at the docs and see that it's meant for Objects

And the object keys of an array are its indices...

> Object.keys([1,2,3])
[ '0', '1', '2' ]

But also... wat

@christopher-dG
Copy link
Contributor

christopher-dG commented Jun 23, 2020

!rebuild introduction

annoying, it seems like GH takes a few minutes to pick up changes to a repo containing an Action

@christopher-dG
Copy link
Contributor

!rebuild introduction

praying to the cache gods

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

!rebuild introduction

Fixed a bug, I think

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

!rebuild introduction

another one...

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

Sweet, all 5 are finished and successful 🙂

@ChrisRackauckas ChrisRackauckas merged commit abc3af9 into master Jun 24, 2020
@ChrisRackauckas ChrisRackauckas deleted the rebuild/301112f1 branch June 24, 2020 00:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants