Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DiffEqBio tutorial #51

Merged
merged 5 commits into from
Mar 11, 2019

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Mar 10, 2019

Only html, script and notebook generated due to tex issues with Weave, see 50. No footer due to 48. I can update in the future once these issues are straightened out.

@isaacsas
Copy link
Member Author

I tweaked the footer to say "this tutorial" instead of "these benchmarks", and also added an optional kwarg to swap out a user's homedir() with ~ (which I used for the diffeqbio tutorial). I can revert these if either is a problem, but I'd prefer not to have my username in the tutorial (which on my mac is part of the path).

@@ -57,11 +57,11 @@ function weave_folder(folder)
end
end

function tutorial_footer(folder=nothing, file=nothing)
function tutorial_footer(folder=nothing, file=nothing; remove_homedir=false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably just default this to true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll change that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fixed

@ChrisRackauckas ChrisRackauckas merged commit e636e0c into SciML:master Mar 11, 2019
@isaacsas isaacsas deleted the debio-introductory-tutorial branch March 11, 2019 22:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants