Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add MOE to separate sub-package #386

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

vikram-s-narayan
Copy link
Contributor

@vikram-s-narayan vikram-s-narayan commented Jul 26, 2022

A separate sub-package is necessary as MOE depends on many other surrogates that are themselves sub-packages (ex: RandomForestSurrogate)

Fixes #259

Items to work on after this PR is merged:

  • Remove MOE from main src directory
  • Remove MOE test from main tests directory
  • Add more tests to MOE sub-package
  • Add documentation for MOE

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #386 (f285356) into master (57a3b89) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   79.65%   79.53%   -0.12%     
==========================================
  Files          16       16              
  Lines        2335     2336       +1     
==========================================
- Hits         1860     1858       -2     
- Misses        475      478       +3     
Impacted Files Coverage Δ
src/Optimization.jl 72.05% <0.00%> (-0.28%) ⬇️
src/Surrogates.jl 21.73% <0.00%> (+3.55%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChrisRackauckas ChrisRackauckas merged commit c1b8397 into SciML:master Jul 26, 2022
@ChrisRackauckas
Copy link
Member

That Project.toml will need compats before registering it.

@vikram-s-narayan vikram-s-narayan mentioned this pull request Jul 26, 2022
6 tasks
@vikram-s-narayan vikram-s-narayan deleted the moe-sub-package branch July 27, 2022 07:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOE tests are commented out
2 participants