Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clone some APIs from DoubleTensorAlgebra to Nd4j, fix #348 #353

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Clone some APIs from DoubleTensorAlgebra to Nd4j, fix #348 #353

wants to merge 1 commit into from

Conversation

CommanderTvis
Copy link
Collaborator

No description provided.

@CommanderTvis CommanderTvis requested a review from grinisrit May 24, 2021 15:19
@CommanderTvis CommanderTvis added feature A new feature request performance Performance optimization issue labels May 24, 2021
grinisrit
grinisrit requested changes May 24, 2021
View reviewed changes
Copy link
Member

@grinisrit grinisrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test like this one: https://github.com/mipt-npm/kmath/blob/12805712d3a42092c7b4ca65c1fd2507acf2c0f3/kmath-tensors/src/commonTest/kotlin/space/kscience/kmath/tensors/core/TestDoubleLinearOpsAlgebra.kt#L166

@CommanderTvis CommanderTvis marked this pull request as draft June 9, 2021 14:43
@CommanderTvis
Copy link
Collaborator Author

Blocked by https://youtrack.jetbrains.com/issue/KT-46899 because I don't see a concise way to share test cases code.

@CommanderTvis CommanderTvis linked an issue Jul 30, 2021 that may be closed by this pull request
Nd4j: Provide faster implementation of diagonalEmbedding in Nd4jTensorAlgebra #348
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@grinisrit grinisrit grinisrit requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature A new feature request performance Performance optimization issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nd4j: Provide faster implementation of diagonalEmbedding in Nd4jTensorAlgebra
2 participants
@CommanderTvis @grinisrit