Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Resolve rubocop error #69

Open
athityakumar opened this issue Nov 17, 2017 · 0 comments
Open

Resolve rubocop error #69

athityakumar opened this issue Nov 17, 2017 · 0 comments
Assignees
@athityakumar
Labels
ready Repo setup

Comments

@athityakumar
Copy link
Member

With the new version rollouts of rubocop-rspec gem in November, RSpec/ContextWording has been added. This enforces context descriptions to begin with 'when', 'with', or 'without'.

I think this makes sense for us to update the wordings as per this rule, as "with data from X data source" does seem more readable (IMO) than "reads data from X data source".
@athityakumar athityakumar self-assigned this Nov 17, 2017
mrkn added a commit to mrkn/daru-io that referenced this issue Dec 7, 2017
@mrkn
Fix for rubocop-rspec 0.20.1
3d8bea5 
Fixes SciRuby#69
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@athityakumar athityakumar

Labels
ready Repo setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@athityakumar