Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove '|' from filenames for Windows #144

Merged
merged 2 commits into from
Feb 25, 2019
Merged

remove '|' from filenames for Windows #144

merged 2 commits into from
Feb 25, 2019

Conversation

kojix2
Copy link
Member

@kojix2 kojix2 commented Feb 15, 2019

Fixes #70

| --> -

Rename *.ipynb files in dummy_iruby directory for Windows.
| (vertical bar) is not assigned to a directory or file in Windows 10.

I confirmed that this branch can be installed on Windows.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.12%

Totals Coverage Status
Change from base Build 780: -0.003%
Covered Lines: 3131
Relevant Lines: 3191

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.12%

Totals Coverage Status
Change from base Build 780: -0.003%
Covered Lines: 3131
Relevant Lines: 3191

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.12%

Totals Coverage Status
Change from base Build 780: -0.003%
Covered Lines: 3131
Relevant Lines: 3191

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.12%

Totals Coverage Status
Change from base Build 780: -0.003%
Covered Lines: 3131
Relevant Lines: 3191

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 15, 2019

Pull Request Test Coverage Report for Build 784

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 98.118%

Totals Coverage Status
Change from base Build 780: -0.005%
Covered Lines: 3128
Relevant Lines: 3188

💛 - Coveralls

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the names of ipynb files first and run all the IRuby notebook cell to check everything is fine, then make checkpoints ?

Thanks!

@Shekharrajak
Copy link
Member

You can also share the link of notebook like this : https://nbviewer.jupyter.org/github/shekharrajak/daru-view/tree/master/spec/dummy_iruby/

@kojix2
Copy link
Member Author

kojix2 commented Feb 17, 2019

OK. I understand.
But I am a Ubuntu user. I do not always use Windows, so please give me some time.

@Shekharrajak
Copy link
Member

@kojix2 , sure ! Thanks for update.

@kojix2
Copy link
Member Author

kojix2 commented Feb 21, 2019

I execute most of dummy_iruby notebooks on Windows.
https://nbviewer.jupyter.org/github/kojix2/daru-view/tree/check-iruby-win/spec/dummy_iruby/

jupyte nbconvert --to notebook --inplace --exec *.ipynb

The three files below stop with errors.

  • Daru DataFrame and DataTables.ipynb
  • DataTables - basic examples.ipynb
  • Nyaplot other examples.ipynb

However, it may not be related to Windows.

That's enough for today.
Running Ruby scripts on Windows is a bit painful, I think.

@Shekharrajak
Copy link
Member

Shekharrajak commented Feb 21, 2019

Thanks @kojix2 , for update.

  • Daru DataFrame and DataTables.ipynb
  • DataTables - basic examples.ipynb

Currently we don't care about datatables examples in IRuby notebook (refer : Shekharrajak/daru-data_tables#2)

But Nyaplot should work as it is . I see all Nyaplot examples are not working. Did you run all the cells (because commit changes are saying 'renamed without changes')?

@Shekharrajak
Copy link
Member

I think you are not using any isolated container. You can try docker container. Pull the windows OS and try to run it. For ubuntu dockerfile sample is written in wiki page : https://github.com/SciRuby/daru-view/wiki/Docker-image-setup

@kojix2
Copy link
Member Author

kojix2 commented Feb 22, 2019

Thanks for your help @Shekharrajak

But I have never used Docker myself. I heard from various people that docker is useful, but I never used it before. I have to learn about Docker.

Actually, I am not a computer engineer, I am a student researcher of medical biology.
My goal is to be able to install daru-view with gem install daru-view command on my co-worker's Windows PCs. I want to make my IRuby Notebooks work on other people's PCs to advance my research.

Nyaplot is old and not maintained, so I think it is not recommended to use it.

Daru::View is best plotting library as far as I know in 2019.
Therefore, I think making it work on Windows is very important for me (and other people).

So I am not sticking to this pull request itself.
Would you please solve this problem with your help?

@Shekharrajak
Copy link
Member

Thanks @kojix2, for letting me know ! Give me few hours.

@Shekharrajak
Copy link
Member

@kojix2 , Since you already have the source code of daru-view gem. This simple thing you can do if you are in hurry :

dummy_iruby have nothing to do in installation of the daru-view gem and it is just written for reference and demonstrating the powerful features of daru-view gem.So you can delete it and build the gem locally, share the generated gem file and install it in system you want.

Steps :

  1. git clone https://github.com/SciRuby/daru-view
  2. Delete the daru-view/spec/dummy_iruby folder.
  3. Go inside the foldeer cd daru-view
  4. build the gem locally using gem build daru-view.gemspec
  5. Now you have daru-view.gem file that can be installed using gem install daru-view.gem
    (Note: Generated file name will be daru-view-version-number.gem)

I followed the above steps and generated gem can be found here: https://github.com/Shekharrajak/daru-view-gem-file

Let me know if you still found any difficulty in windows system.

@kojix2
Copy link
Member Author

kojix2 commented Feb 22, 2019

Thank you very much @Shekharrajak
I'm sorry to rush you. I am Okay.
I knew the steps you write, and I could install daru-view gem from my branch too.

gem specific_install https://github.com/kojix2/daru-view.git patch-windows

I just want you to release a new gem that we can install gem on windows from Gem server.
(and not in a hurry).

@Shekharrajak
Copy link
Member

@kojix2 , thanks for update . I have cherry picked your commits and fixed the problem in #147

@Shekharrajak Shekharrajak merged commit 1cb58d4 into SciRuby:master Feb 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants