Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix gcc capability check #632

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

plprofetes
Copy link

Current implementation supports g++ 4.x only, when checking c++11 support.

Fix assumes that any g++ newer than 4 does support c++11.

It allows compiling nmatrix on modern g++ versions.

fixes #630

b08x added a commit to b08x/nmatrix that referenced this pull request Nov 7, 2023
@mishelhiti
Copy link

hey,
can you please share if there is a way to install this gem with your fix besides waiting for it to merge to main?

@KirtashW17
Copy link

KirtashW17 commented May 16, 2024

hey, can you please share if there is a way to install this gem with your fix besides waiting for it to merge to main?

Hi,
You could install the gem from github adding this to your Gemfile:

gem 'nmatrix', git: 'https://github.com/plprofetes/nmatrix' # plprofetes version

or #633

gem 'nmatrix', git: 'https://github.com/KirtashW17/nmatrix_gpp10' # my version

@mishelhiti
Copy link

mishelhiti commented May 16, 2024

Sorry for not knowing this but where is the Gemfile located?
like what is the full set of cmds i need to run on windows to make it work?

@KirtashW17
Copy link

KirtashW17 commented May 16, 2024

If you use Bundler, your Ruby project will have a Gemfile in the root that specifies all the dependencies of your project.
If you're trying to globally install the gem, you could try to follow the steps mentioned here: https://stackoverflow.com/a/2577404

  1. Clone plprofetes or my repo
  2. run gem build nmatrix.gemspec
  3. run gem install nmatrix-0.2.4.gem

@mishelhiti
Copy link

didn't work...
how did you managed to bypass the gcc version check?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'10.2.1' < '4.3.0' is true
3 participants