Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Transverse Mercator support negative scanning #296

Merged
merged 6 commits into from
Apr 25, 2022

Conversation

trexfeathers
Copy link
Contributor

Have been able to confirm that this behaviour handles a file as expected, thanks to @MoseleyS and @edwardccsteele.

@trexfeathers trexfeathers changed the title Transverse Mercator support negative Y scanning Transverse Mercator support negative scanning Apr 14, 2022
@trexfeathers
Copy link
Contributor Author

trexfeathers commented Apr 14, 2022

Have expanded the scope to support negative scanning in either direction, following conversation with @pp-mo.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warning/error messages need to be clearer.
Otherwise OK now, I think.

iris_grib/_load_convert.py Outdated Show resolved Hide resolved
iris_grib/_load_convert.py Outdated Show resolved Hide resolved
@pp-mo
Copy link
Member

pp-mo commented Apr 25, 2022

Thanks @trexfeathers !

@pp-mo pp-mo merged commit a4bed1a into SciTools:main Apr 25, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants