Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add pytest-mock dependency #424

Merged
merged 1 commit into from
Apr 16, 2024
Merged

add pytest-mock dependency #424

merged 1 commit into from
Apr 16, 2024

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Apr 16, 2024 •
edited
Loading

This pull-request removes the mock package, which is not needed as it is now bundled with core python through unittest.

It also adds the pytest-mock plugin package in preparation to support the eventual migration of our tests to pytest, given #420 has now landed.

@bjlittle bjlittle self-assigned this Apr 16, 2024
@bjlittle bjlittle requested a review from stephenworsley April 16, 2024 14:57
stephenworsley
stephenworsley approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephenworsley stephenworsley merged commit ffa2133 into SciTools:main Apr 16, 2024
8 checks passed
@trexfeathers trexfeathers linked an issue Apr 17, 2024 that may be closed by this pull request
Add pytest-mock to deps #422
Closed
@trexfeathers trexfeathers mentioned this pull request Aug 30, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stephenworsley stephenworsley stephenworsley approved these changes

Assignees

@bjlittle bjlittle

@stephenworsley stephenworsley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pytest-mock to deps
2 participants
@bjlittle @stephenworsley