Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove MyPy redundant-expr error #497

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Remove MyPy redundant-expr error #497

merged 3 commits into from
Jul 15, 2024

Conversation

githubalexliu
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2024

CLA assistant check
All committers have signed the CLA.

@pp-mo
Copy link
Member

pp-mo commented Jul 1, 2024

Thanks @githubalexliu this is useful.
But, from the error, I think this change is still incomplete :
It seems that since we also adopted checking against the "repo-review" recommendations, this now complains because repo-review recommends that this MyPy option is enabled (!!).

So, I think you need to add something to the configuration of repo-review, presumably in this section of pyproject.toml.
Presumably, we just need to add "MY105" to the list of ignores here, along with the existing MY102.

As it's so simple, I won't bother you with a PP-to-PR : can you perhaps make this change + see if it works ?

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (0e49a55) to head (cee3566).
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files           8        8           
  Lines        2467     2467           
  Branches      418      418           
=======================================
  Hits         2199     2199           
  Misses        170      170           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member

pp-mo commented Jul 9, 2024

Thanks @githubalexliu
I can't explain why the 3.12 tests failed like that, since nothing relevant changed (including the lockfiles)
And on re-spin went ok ??

Anyway, all good now I think !

@pp-mo
Copy link
Member

pp-mo commented Jul 9, 2024

Oh I hadn't seen, we are also blocked on CLA.
Can you # for this, @githubalexliu ?

@pp-mo pp-mo merged commit 6b97a7e into SciTools:main Jul 15, 2024
10 checks passed
@pp-mo
Copy link
Member

pp-mo commented Jul 15, 2024

Thanks @githubalexliu !
Sorry for delay, spent whole of last week focussing on SciPy2024

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants