Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

RUFF: fix legacy use of np.numpy.random #5786

Merged
merged 3 commits into from
Feb 27, 2024
Merged

RUFF: fix legacy use of np.numpy.random #5786

merged 3 commits into from
Feb 27, 2024

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Feb 26, 2024 •
edited
Loading

🚀 Pull Request

Description

Fixes the NPY002 error in ruff. This rule was introduced in a recent ruff release https://github.com/astral-sh/ruff/releases/tag/v0.2.2.

$ ruff .
lib/iris/tests/unit/util/test_broadcast_to_shape.py:24:13: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`
lib/iris/tests/unit/util/test_broadcast_to_shape.py:31:13: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`       
lib/iris/tests/unit/util/test_broadcast_to_shape.py:40:13: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`       
lib/iris/tests/unit/util/test_broadcast_to_shape.py:59:13: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`       
lib/iris/tests/unit/util/test_broadcast_to_shape.py:69:13: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`       
lib/iris/tests/unit/util/test_broadcast_to_shape.py:79:13: NPY002 Replace legacy `np.random.random` call with `np.random.Generator`       
Found 6 errors.

Consult Iris pull request check list

@tkknight tkknight marked this pull request as ready for review February 26, 2024 15:47
@bjlittle bjlittle self-requested a review February 27, 2024 15:35
bjlittle
bjlittle approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Nice one 👍

LGTM

@bjlittle bjlittle merged commit f4e2fb7 into SciTools:main Feb 27, 2024
18 checks passed
@tkknight tkknight deleted the ruff_numpy branch February 27, 2024 15:38
@tkknight tkknight mentioned this pull request Feb 27, 2024
Merged
@bjlittle bjlittle self-assigned this Feb 27, 2024
tkknight added a commit to tkknight/iris that referenced this pull request Feb 27, 2024
@tkknight
Merge branch 'main' into replace_napolean_with_numpydoc
27101b4 
* main:
  ASV custom build command and file-based benchmark triggers (SciTools#5776)
  DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762)
  RUFF: fix legacy use of np.numpy.random (SciTools#5786)
stephenworsley pushed a commit to stephenworsley/iris that referenced this pull request Mar 11, 2024
@tkknight @stephenworsley
RUFF: fix legacy use of np.numpy.random (SciTools#5786)
9a1e5ac 
* fix numpy (ruff NPY002)

* handle test with dask array.
pp-mo pushed a commit to pp-mo/iris that referenced this pull request Mar 11, 2024
@tkknight @pp-mo
RUFF: fix legacy use of np.numpy.random (SciTools#5786)
59e6c6d 
* fix numpy (ruff NPY002)

* handle test with dask array.
pp-mo pushed a commit to pp-mo/iris that referenced this pull request Mar 11, 2024
@tkknight @pp-mo
RUFF: fix legacy use of np.numpy.random (SciTools#5786)
6b820ad 
* fix numpy (ruff NPY002)

* handle test with dask array.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bjlittle bjlittle

Assignees

@bjlittle bjlittle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkknight @bjlittle