Refactored service to bun #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added structured logging Added graceful shutdown
|
This pull request has been linked to Shortcut Story #34146: html-pdf-exporter omzetten naar structured logging (pino non-pretty). |
annervisser
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
@luukvhoudt Wat mij betreft akkoord. Maar stel voor om nog wel wat moeite te steken in het testen hiervan. Zowel handmatig als geautomatiseerd.
Idee om dit niet rechtstreeks naar develop te mergen maar naar een 2.x branch?
iig lijkt het me goed om het te deployen naar acpt en dan een aantal formulieren erdoorheen te halen. En een playwright test die de pdf snapshot zou ook tof zijn (even kijken hoe haalbaar dat is, pdfjs in browser en dat dat screenshotten?)
luukvhoudt
deleted the
chore/sc-34146/html-pdf-exporter-omzetten-naar-structured
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added structured logging
Added graceful shutdown