Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(test-bin): Only write output file in CI and fix trailing whitespaces #4613

Merged
merged 4 commits into from
Dec 30, 2021
Merged

test(test-bin): Only write output file in CI and fix trailing whitespaces #4613

merged 4 commits into from
Dec 30, 2021

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Dec 30, 2021 •
edited
Loading

Description

Only produce test result file while run by CI and fix two styling failure.

Motivation and Context

When run test\bin\test.ps1 locally, it will produce TestResults.xml file and give a failure on next run.

Also fix duplicate license item in schema.json and trailing space in libexec\scoop-prefix.ps1

How Has This Been Tested?

Running test\bin\test.ps1

Before:
image
image

After:
image
image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven niheaven merged commit 5d8aeb5 into develop Dec 30, 2021
@niheaven niheaven deleted the fix-whitespaces branch December 30, 2021 18:14
@niheaven niheaven mentioned this pull request Mar 2, 2022
Merged
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@niheaven @se35710
test(test-bin): Only write output file in CI and fix trailing whitesp…
3de0161 
…aces (ScoopInstaller#4613)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000