Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(decompress): Fix Split-Path -LeafBase in PS5 #4639

Merged
merged 2 commits into from
Jan 10, 2022
Merged

fix(decompress): Fix Split-Path -LeafBase in PS5 #4639

merged 2 commits into from
Jan 10, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 10, 2022 •
edited
Loading

Description

Split-Path in PowerShell 5 don't have LeafBase switch, so changed Split-Path $Path -LeafBase to strip_ext (fname $Path).

Motivation and Context

Relates to #4608

How Has This Been Tested?

Tested by .\test\bin\test.ps1 in PowerShell 5.1

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven niheaven changed the title fix(decompress): Fix nested zstd in PS5 fix(decompress): Fix Split-Path -LeafBase in PS5 Jan 10, 2022
@niheaven niheaven merged commit 3ca1b1f into develop Jan 10, 2022
@niheaven niheaven deleted the fix-nested-zstd branch January 10, 2022 06:22
@niheaven niheaven mentioned this pull request Mar 2, 2022
Merged
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@niheaven @se35710
fix(decompress): Fix Split-Path -LeafBase in PS5 (ScoopInstaller#4639)
9afe8b2
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000