Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(scoop-bucket): Check for git before running command #4756

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

rashil2000
Copy link
Member

Hotfix for #4704

libexec/scoop-bucket.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@niheaven
Copy link
Member

The code LGTM, please update CHANGLOG

@rashil2000 rashil2000 merged commit 40b2d95 into develop Feb 24, 2022
@rashil2000 rashil2000 deleted the fix-bucket-git branch February 24, 2022 09:41
@HUMORCE
Copy link
Member

HUMORCE commented Feb 24, 2022

> scoop bucket list
Get-Date: C:\Users\HUMOR\scoop\apps\scoop\current\libexec\scoop-bucket.ps1:42
Line |
  42 |  …  --date=format:"`"%d-%m-%Y %H:%M:%S`"" --format='%ad' -n 1 | Get-Date
     |                                                                 ~~~~~~~~
     | The input object cannot be bound to any parameters for the command either because the command does not
     | take pipeline input or the input and its properties do not match any of the parameters that take
     | pipeline input.
...

@rashil2000
Copy link
Member Author

image

image

How to reproduce?

@HUMORCE
Copy link
Member

HUMORCE commented Feb 24, 2022

screenshot_20220224164358

@HUMORCE
Copy link
Member

HUMORCE commented Feb 24, 2022

%ad
author date (format respects --date= option)

%aD
author date, RFC2822 style

if date formatting is not required, use %aD:

> git log --format='%aD' -n 1 | Get-Date

Thursday, February 24, 2022 12:03:00 PM

@rashil2000
Copy link
Member Author

image

image

PowerShell 5.1

@rashil2000
Copy link
Member Author

if date formatting is not required, use %aD:

Hmm, okay. Seems fine by me. Can you fix it?

@HUMORCE
Copy link
Member

HUMORCE commented Feb 24, 2022

screenshot_20220224170745

related to OS's datetime format. (unconfirmed)

se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
…er#4756)

* fix(scoop-bucket): Check for git before running command

* Apply suggestions from code review

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants