Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(manifest): Fix bugs in 'Get-Manifest()' #4986

Merged
merged 3 commits into from
Jun 14, 2022
Merged

fix(manifest): Fix bugs in 'Get-Manifest()' #4986

merged 3 commits into from
Jun 14, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jun 13, 2022

Description

There're some bugs in #4966 and one of them is fixed in #4970. This PR fixes them all.

  • 'Get-Dependency()' may return wrong app name when it's a path
  • Trim starting "/" if there is no bucket
  • Don't return wrong 'versions' bucket for local manifest

Motivation and Context

How Has This Been Tested?

  • scoop install xxx@xxx

image

  • scoop install \path\to\json\that\not\existed

image

  • scoop install \path\to\json

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven requested review from HUMORCE and rashil2000 and removed request for HUMORCE June 14, 2022 05:09
@niheaven niheaven merged commit 0b38c91 into develop Jun 14, 2022
@niheaven niheaven deleted the fix-manifest branch June 14, 2022 06:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants