-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(scoop-import): Use foreach
instead of ForEach-Object
for nullity check
#5034
Conversation
I've made some tweaks:
|
foreach
instead of ForEach-Object
for nullity check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I agree that "if a bucket already exists, we want to show an error while importing", but currently the resulted warning and hint is misleading in this context, especially: |
Make warning clearer Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
…ity check (ScoopInstaller#5034) * Add nullity check and alread_in_local_bucket check * update CHANGELOG * Use foreach instead of ForEach-Object * changelog * update help * refine the info and warning when adding an already-added bucket * Update lib/buckets.ps1 Make warning clearer Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com> Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Description
Check whether the wanted property of bucket is null.
Check if the to-be-imported bucket is already added locally
Context
Closes #5033