Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(scoop-update): Add support for pre_uninstall and post_uninstall #5085

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

yi-Xu-0100
Copy link
Contributor

@yi-Xu-0100 yi-Xu-0100 commented Aug 5, 2022

The $cmd in Pre-Post-(un)install-scripts says that the scoop-update should support the pre_uninstall and the post_uninstall, but it did not use the scoop-uninstall so that the pre_uninstall and the post_uninstall were missed.

Description

Add support for pre_uninstall and post_uninstall.

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title feat(scoop-update): add support for pre_uninstall and post_uninstall feat(scoop-update): Add support for pre_uninstall and post_uninstall Aug 6, 2022
@niheaven niheaven merged commit 7bfef49 into ScoopInstaller:develop Aug 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants