Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(install): Replace 'run_(un)installer()' with 'Invoke-Installer()' #5968

Merged
merged 3 commits into from
May 15, 2024
Merged

refactor(install): Replace 'run_(un)installer()' with 'Invoke-Installer()' #5968

merged 3 commits into from
May 15, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 14, 2024 •
edited
Loading

Description

  • Refactor run_installer() and run_uninstaller()
  • Add hook type installer and uninstaller to Invoke-HookScript()
  • Remove one-time used function args()

Motivation and Context

How Has This Been Tested?

Tested with scoop install hack-font and scoop uninstall hack-font w/ other manifests.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven merged commit 2544745 into develop May 15, 2024
2 checks passed
@niheaven niheaven deleted the refactor-installer branch May 15, 2024 11:03
@niheaven niheaven mentioned this pull request May 15, 2024
Merged
5 tasks
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024
@niheaven @brian6932
refactor(install): Replace 'run_(un)installer()' with 'Invoke-Install…
af5f5df 
…er()' (ScoopInstaller#5968)
@niheaven niheaven mentioned this pull request Jun 30, 2024
Merged
niheaven added a commit that referenced this pull request Jun 30, 2024
@niheaven
refactor(install): Replace 'run_(un)installer()' with 'Invoke-Install…
008095a 
…er()' (#5968)
This was referenced Jul 8, 2024
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niheaven