Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

F_40B: Resource Limits [feature to main] #881

Merged
merged 13 commits into from
Aug 4, 2022
Merged

F_40B: Resource Limits [feature to main] #881

merged 13 commits into from
Aug 4, 2022

Conversation

rohitkolapkar
Copy link
Contributor

Pull Request

Problem Statement

CORTX-30330: Resource Quota Update
CORTX-30331: active users quota
CORTX-30332: POC for operations quota
CORTX-32714: resource limits amendments

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Alexander Voronov and others added 13 commits May 17, 2022 14:17
CORTX-30331: active users quota (#824)
0ca283a 
* CORTX-30331: implement the session manager that maintains quota

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30331: refactor the login procedure

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30331: integrate the session manager with active users quota

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30331: debug the solution

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>
CORTX-30332: POC for operations quota (#832)
749c4ff 
* CORTX-30332: POC for operations quota

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30332: update throttler middleware from POC to production

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30332: set CSM request quota at Configure phase

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30332: add sessions quota

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30332: reserve some memory for CSM future needs

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-30332: resolve PR comments

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>
@pawankumarsrivastava
Resolving conflicts
03fa946 
Signed-off-by: Pawan Kumar Srivastava <pawan.kumarsrivastava@seagate.com>
@abhijit1patil
CORTX-30330: Resource Quota Update (#858)
34668e9 
* Modification for one session per user

Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>

* Updated session expiry time and updated the req calulation formulae

Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>

* Await update method

Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>

* logs updated

Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>
CORTX-32714: resource limits amendments (#869)
a091dfd 
* CORTX-32714: make active users quota configurable

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-32714: allow 'infinite' value for maximum number of users limit

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-32714: remove redundant sessions quota checks

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-32714: fix error description for active users quota

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

* CORTX-32714: make active users quota infinite by default

Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>
@abhijit1patil
Merge branch 'main' into F_40B_Resource_Limits
4bcb683
@abhijit1patil
Merge branch 'main' into F_40B_Resource_Limits
1842122
@abhijit1patil
Codacy Issue: _remove_expired_sessions signature updated
fbccb14 
Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>
@abhijit1patil
CORTX-33700: Handled exception in throttler middleware and added comm…
cbdefe8 
…ents (#876)

* Handled exception in throttler middleware and added comments

Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>

* Codacy Issue handled

Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>
@abhijit1patil
Resource Limit is set to calculations (#877)
e34e044 
Signed-off-by: abhijit1patil <abhijit.1.patil@seagate.com>
@avrnv
CORTX-33726: fix race condition on users quota check (#878)
20b108d 
Signed-off-by: Alexander Voronov <alexander.voronov@seagate.com>

Co-authored-by: Alexander Voronov <alexander.voronov@seagate.com>
Merge branch 'main' of https://github.com/Seagate/cortx-manager into …
bc125fd 
…F_40B_Resource_Limits

Conflicts:
	csm/core/agent/api.py
	csm/core/services/sessions.py
CORTX-33835: Fix CSM mini-provisioning failure (#880)
76f79bf 
* Fixing user service initialisation

Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>

* User management test cases updated

Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
@cla-bot
Copy link

cla-bot bot commented Aug 3, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alexander Voronov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@kupranay kupranay merged commit 76555d1 into main Aug 4, 2022
@rohitkolapkar rohitkolapkar deleted the F_40B_Resource_Limits branch August 8, 2022 11:41
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@pawankumarsrivastava pawankumarsrivastava pawankumarsrivastava approved these changes

@kupranay kupranay kupranay approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@Pranali04796 Pranali04796 Awaiting requested review from Pranali04796

@soniyamoholkar soniyamoholkar Awaiting requested review from soniyamoholkar

Assignees

@soniyamoholkar soniyamoholkar

@pawankumarsrivastava pawankumarsrivastava

@ajaysrivas ajaysrivas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rohitkolapkar @pawankumarsrivastava @kupranay @soniyamoholkar @ajaysrivas @abhijit1patil @avrnv