Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

CORTX-33740 : Analyse and fix memory leaks created by ctg module using s3 IOs. #2098

Merged
merged 6 commits into from
Aug 29, 2022
Merged

CORTX-33740 : Analyse and fix memory leaks created by ctg module using s3 IOs. #2098

merged 6 commits into from
Aug 29, 2022

Conversation

upendrapatwardhan
Copy link
Contributor

Fix memory leaks for ctg module.

Signed-off-by: Upendra Patwardhan upendra.patwardhan@seagate.com

Problem Statement

  • Problem statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

@upendrapatwardhan
Fix memory leaks for ctg module.
8822037 
Signed-off-by: Upendra Patwardhan <upendra.patwardhan@seagate.com>
@cla-bot cla-bot bot added the cla-signed label Aug 23, 2022
mehjoshi
mehjoshi reviewed Aug 23, 2022
View reviewed changes
@rkothiya
Copy link
Contributor

Jenkins CI Result : Motr#1624

Motr Test Summary

Test ResultCountInfo
❌Failed2
📁

04motr-single-node/49motr-rpc-cancel
01motr-single-node/00userspace-tests

🏁Skipped32
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed43
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/73motr-io-small-disks
04motr-single-node/48motr-raid0-io
04motr-single-node/74motr-di-corruption-detection
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total77🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

imvenkip
imvenkip reviewed Aug 25, 2022
View reviewed changes
imvenkip
imvenkip reviewed Aug 25, 2022
View reviewed changes
@upendrapatwardhan
Add separate function for dead index catalogue operations.
8a86abf 
Remove unwanted spaces.

Signed-off-by: Upendra Patwardhan <upendra.patwardhan@seagate.com>
@upendrapatwardhan
Free ctg->cc_tree based on return value of m0_ctg_drop().
56f73a5 
Signed-off-by: Upendra Patwardhan <upendra.patwardhan@seagate.com>
@upendrapatwardhan
Merge branch 'main' into CORTX-33740_fix_ctg_leaks
7cbe7ea
@upendrapatwardhan
Add new function for deleting a ctg from the dead index catalogue.
5770eb9 
Signed-off-by: Upendra Patwardhan <upendra.patwardhan@seagate.com>
@rkothiya
Copy link
Contributor

Jenkins CI Result : Motr#1655

Motr Test Summary

Test ResultCountInfo
❌Failed2
📁

04motr-single-node/49motr-rpc-cancel
01motr-single-node/00userspace-tests

🏁Skipped32
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed43
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/73motr-io-small-disks
04motr-single-node/48motr-raid0-io
04motr-single-node/74motr-di-corruption-detection
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total77🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

imvenkip
imvenkip approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@imvenkip imvenkip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rkothiya rkothiya merged commit 6c3541f into Seagate:main Aug 29, 2022
kiwionly2 pushed a commit to kiwionly2/cortx-motr that referenced this pull request Aug 30, 2022
@upendrapatwardhan @kiwionly2
CORTX-33740: Fix memory leaks created by ctg module using s3 IOs. (Se…
8386d2c 
…agate#2098)

* Add separate function for dead index catalogue operations. 
* Free ctg->cc_tree based on return value of m0_ctg_drop().
* Add new function for deleting a ctg from the dead index catalogue.

Signed-off-by: Upendra Patwardhan <upendra.patwardhan@seagate.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@mehjoshi mehjoshi mehjoshi approved these changes

@imvenkip imvenkip imvenkip approved these changes

@vidyadhar-pinglikar vidyadhar-pinglikar vidyadhar-pinglikar approved these changes

@kanchan-chaudhari kanchan-chaudhari Awaiting requested review from kanchan-chaudhari

@Vinoth2101 Vinoth2101 Awaiting requested review from Vinoth2101

@JugalPatil JugalPatil Awaiting requested review from JugalPatil

@madhavemuri madhavemuri Awaiting requested review from madhavemuri

@nikitadanilov nikitadanilov Awaiting requested review from nikitadanilov

@yeshpal-jain-seagate yeshpal-jain-seagate Awaiting requested review from yeshpal-jain-seagate

@huanghua78 huanghua78 Awaiting requested review from huanghua78

@andriytk andriytk Awaiting requested review from andriytk andriytk is a code owner

@siningwuseagate siningwuseagate Awaiting requested review from siningwuseagate siningwuseagate is a code owner

@shashank-parulekar shashank-parulekar Awaiting requested review from shashank-parulekar

@nkommuri nkommuri Awaiting requested review from nkommuri nkommuri is a code owner

@sg-shankar sg-shankar Awaiting requested review from sg-shankar

@yatin-mahajan yatin-mahajan Awaiting requested review from yatin-mahajan

@rkothiya rkothiya Awaiting requested review from rkothiya

Assignees

@nikitadanilov nikitadanilov

@madhavemuri madhavemuri

@mehjoshi mehjoshi

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@upendrapatwardhan @rkothiya @mehjoshi @imvenkip @vidyadhar-pinglikar @nikitadanilov @madhavemuri