Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-30240: Enabling back RGW stdout/stderr logging after confirming IO tests performance results #130

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

cdeshmukh
Copy link
Contributor

@cdeshmukh cdeshmukh commented Sep 9, 2022

Enabled back RGW stdout/stderr logging

Signed-off-by: Chetan S. Deshmukh chetan.deshmukh@seagate.com

Problem Statement

  • RGW stdout/stderr logging was disabled owing to performance regression reported in CORTX-33944

Design

  • After this change was merged, perf issue was resolved, removing code which was reading libMotr log o/p line by line, and prepending timestamp & then pushing it to stdout/stderr

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

@cla-bot cla-bot bot added the cla-signed label Sep 9, 2022
…formance results

Signed-off-by: Chetan S. Deshmukh <chetan.deshmukh@seagate.com>
@cdeshmukh cdeshmukh force-pushed the CORTX-30240-rgw-enable-stdout-logging branch from 793c282 to ea2bec7 Compare September 9, 2022 09:36
@cdeshmukh cdeshmukh marked this pull request as ready for review September 9, 2022 09:36
@shailesh-vaidya
Copy link
Contributor

retest this please

@cdeshmukh cdeshmukh merged commit 7290b27 into main Sep 12, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants