Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-33672: added deployment time in Query deployemnt #866

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

lakshita-jain
Copy link
Contributor

@lakshita-jain lakshita-jain commented Aug 3, 2022

Signed-off-by: Lakshita Jain lakshita.jain@seagate.com

Problem Statement

  • add deployment_time field in the topology/ output of query_deployment which will be used by CSM.

Design

extracting 'time' field from 'provisioning' under each node as part of node_info for each node in query deployment output

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
  • Confirm that Test Cases are added for new features added [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]:

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

Signed-off-by: Lakshita Jain <lakshita.jain@seagate.com>
Copy link

@nitin-seagate nitin-seagate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanujashinde0405 tanujashinde0405 merged commit 354921e into Seagate:main Aug 4, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants