Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for basic authentication to external ES platform #110

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

telendt
Copy link
Contributor

@telendt telendt commented Mar 12, 2020

Currently external Elasticsearch setup does not support basic auth (encoding user/password into hostUrl does not work - tried that). Elasticsearch REST client documentation shows how this should be done:
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/5.6/_basic_authentication.html

So I've extended index-settings.json with optional user and password params that are used for setting up basic auth (if present).

@telendt
Copy link
Contributor Author

telendt commented Mar 12, 2020

Also, I think it would be helpful if external Elasticsearch archetype (introduced by @mattflax in #65) was documented in the wiki:
https://github.com/SeaseLtd/rated-ranking-evaluator/wiki/Maven%20Archetype

(I had to go through code/GH issues to find out about it.)

@mattflax
Copy link
Contributor

I've updated the Archetypes wiki page to mention the external Elasticsearch archetype.

@agazzarini
Copy link
Member

LGTM!

@agazzarini agazzarini merged commit c64a127 into SeaseLtd:master Mar 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants