Images not deleting #25
Comments
|
Just wondering:
Why are you editing the .json file instead of changing the information in the ACRT app itself? I wonder if you changed a “fail” to “pass” in the .json file if there are other failures for same test-ID or WCAG SC so you get that data, or is the image link retained in the json even if you just changed fail to pass.
It seems to me that using the ACRT itself to make such edits would be better, but that’s just me.
accessibility—helping people get stuff done!
Empathy is motivation
Understanding is means
Agile is opportunity
To commit accessibility!
… On Jun 16, 2021, at 2:34 PM, fareebs ***@***.***> wrote:
Hi, when we edit an existing JSON report and change a failure from "Fail" to "Pass", remove the image, it still generates the image in the HTML report. How do we bypass this? Are we missing a step or is this something with the code? Please contact me at ***@***.*** Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
That’s what we did. We loaded our test results json file. It didn’t save
the updates. It still wants to keep all the images.
On Wed, Jun 16, 2021 at 4:15 PM ahoffman3390 ***@***.***>
wrote:
… Just wondering:
Why are you editing the .json file instead of changing the information in
the ACRT app itself? I wonder if you changed a “fail” to “pass” in the
.json file if there are other failures for same test-ID or WCAG SC so you
get that data, or is the image link retained in the json even if you just
changed fail to pass.
It seems to me that using the ACRT itself to make such edits would be
better, but that’s just me.
accessibility—helping people get stuff done!
Empathy is motivation
Understanding is means
Agile is opportunity
To commit accessibility!
> On Jun 16, 2021, at 2:34 PM, fareebs ***@***.***> wrote:
>
>
> Hi, when we edit an existing JSON report and change a failure from
"Fail" to "Pass", remove the image, it still generates the image in the
HTML report. How do we bypass this? Are we missing a step or is this
something with the code? Please contact me at ***@***.*** Thank you.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKCLV757WNHEGII7N4ZTBDTTEA6BANCNFSM462AWUPQ>
.
|
|
Weird.
Hope someone will update code soon.
I might even give it a try.
I’ve been poking around in that code as a learning exercise for a while now but I learn slow.
Sounds like changing to pass doesn’t remove the previous data so the report output just puts it out regardless of status. The thing I’m thinking about is should the tool remove the failing data when the user changes it to pass from fail, which seems logical, but since sometimes such things waffle back and forth it would be sensible to leave the failing data there but just not show it when reporting unless the element is set to fail. That would allow for not needing to go re-upload the images or such which in some cases is nearly impossible on a second or third review pass. Alternately the user could be asked if they want the failing data to remain in the record or not. When a report is “final”, how such data is treated would be a question also. It doesn’t seem to me that final records should include excess failing data for pass elements so upon setting to fail it would be a good idea to tell the user if there are any lingering failing data elements which don’t appear on the report so they can decide what they want to do with them before making it final.
If forced because you are in a hurry, you could edit the .json file and just remove the offending elements yourself. It isn’t that complex.
I can’t claim responsibility for the coding but sorry you are having this issue.
From: fareebs ***@***.***>
Sent: Wednesday, June 16, 2021 6:10 PM
To: Section508Coordinators/ACRT ***@***.***>
Cc: ahoffman3390 ***@***.***>; Comment ***@***.***>
Sub ject: Re: [Section508Coordinators/ACRT] Images not deleting (#25)
That’s what we did. We loaded our test results json file. It didn’t save
the updates. It still wants to keep all the images.
On Wed, Jun 16, 2021 at 4:15 PM ahoffman3390 ***@***.*** <mailto:***@***.***> >
wrote:
Just wondering:
Why are you editing the .json file instead of changing the information in
the ACRT app itself? I wonder if you changed a “fail” to “pass” in the
.json file if there are other failures for same test-ID or WCAG SC so you
get that data, or is the image link retained in the json even if you just
changed fail to pass.
It seems to me that using the ACRT itself to make such edits would be
better, but that’s just me.
accessibility—helping people get stuff done!
Empathy is motivation
Understanding is means
Agile is opportunity
To commit accessibility!
> On Jun 16, 2021, at 2:34 PM, fareebs ***@***.*** <mailto:***@***.***> > wrote:
>
>
> Hi, when we edit an existing JSON report and change a failure from
"Fail" to "Pass", remove the image, it still generates the image in the
HTML report. How do we bypass this? Are we missing a step or is this
something with the code? Please contact me at ***@***.*** <mailto:***@***.***> Thank you.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKCLV757WNHEGII7N4ZTBDTTEA6BANCNFSM462AWUPQ>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#25 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AONPIREHDXSK6BSBS3UTF4LTTEOKFANCNFSM462AWUPQ> . <https://github.com/notifications/beacon/AONPIRD4LPSKURZ2IDCEYMLTTEOKFA5CNFSM462AWUP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNWLNOA.gif>
|
|
Thanks Al for the suggestions. I doubt I’ll have time, but I’ll see what I
can do with the json file.
On Thu, Jun 17, 2021 at 9:21 AM ahoffman3390 ***@***.***>
wrote:
… Weird.
Hope someone will update code soon.
I might even give it a try.
I’ve been poking around in that code as a learning exercise for a while
now but I learn slow.
Sounds like changing to pass doesn’t removethe previous data so the report
output just puts it out regardless of status. The thing I’m thinking about
is should the tool remove the failing data when the user changes it to pass
from fail, which seems logical, but since sometimes such things waffle back
and forth it would be sensible to leave the failing data there but just not
show it when reporting unless the element is set to fail. That would allow
for not needing to go re-upload the images or such which in some cases is
nearly impossible on a second or third review pass. Alternately the user
could be asked if they want the failing data to remain in the record or
not. When a report is “final”, how such data is treated would be a question
also. It doesn’t seem to me that final records should include excess
failing data for pass elements so upon setting to fail it would be a good
idea to tell the user if there are any lingering failing data elements
which don’t appear on the report so they can decide what they want to do
with them before making it final.
If forced because you are in a hurry, you could edit the .json file and
just remove the offending elements yourself. It isn’t that complex.
I can’t claim responsibility for the coding but sorry you are having this
issue.
From: fareebs ***@***.***>
Sent: Wednesday, June 16, 2021 6:10 PM
To: Section508Coordinators/ACRT ***@***.***>
Cc: ahoffman3390 ***@***.***>; Comment ***@***.***>
Sub ject: Re: [Section508Coordinators/ACRT] Images not deleting (#25)
That’s what we did. We loaded our test results json file. It didn’t save
the updates. It still wants to keep all the images.
On Wed, Jun 16, 2021 at 4:15 PM ahoffman3390 ***@***.*** <mailto:***@***.***>
>
wrote:
> Just wondering:
> Why are you editing the .json file instead of changing the information in
> the ACRT app itself? I wonder if you changed a “fail” to “pass” in the
> .json file if there are other failures for same test-ID or WCAG SC so you
> get that data, or is the image link retained in the json even if you just
> changed fail to pass.
>
> It seems to me that using the ACRT itself to make such edits would be
> better, but that’s just me.
>
>
>
> accessibility—helping people get stuff done!
> Empathy is motivation
> Understanding is means
> Agile is opportunity
> To commit accessibility!
>
>
> > On Jun 16, 2021, at 2:34 PM, fareebs ***@***.*** <mailto:***@***.***>
> wrote:
> >
> >
> > Hi, when we edit an existing JSON report and change a failure from
> "Fail" to "Pass", remove the image, it still generates the image in the
> HTML report. How do we bypass this? Are we missing a step or is this
> something with the code? Please contact me at ***@***.*** <mailto:***@***.***>
Thank you.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub, or unsubscribe.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#25 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/APKCLV757WNHEGII7N4ZTBDTTEA6BANCNFSM462AWUPQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
#25 (comment)>
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AONPIREHDXSK6BSBS3UTF4LTTEOKFANCNFSM462AWUPQ>
. <
https://github.com/notifications/beacon/AONPIRD4LPSKURZ2IDCEYMLTTEOKFA5CNFSM462AWUP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNWLNOA.gif>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKCLV274LLPOQKZONGUCUTTTHZGHANCNFSM462AWUPQ>
.
|
|
This is an ongoing issue. Clicking "Remove Image" removes the image visually but does not remove the underlying code and the image will appear in Reports generated from the JSON and in any new Reports Created from that JSON. I'm sure other people are experiencing this an just not posting in GitHub. |
|
People are often too busy, don't know they can post on Github, or just
workaround the issues. I think I'm the only one that reports these
problems. Nevertheless, I'm about to socialize TT and ACRT to over 400+
system owners and would really like them to not feel frustrated or
disappointed with all the issues. I forwarded a list from another colleague
to Cliff Soon - please coordinate with him to see all the known issues.
Thank you.
Best,
Fariba Beg
alternate email - ***@***.***
mobile - 240-340-7353
…On Wed, Jul 3, 2024 at 11:29 AM raebened2 ***@***.***> wrote:
This is an ongoing issue. Clicking "Remove Image" removes the image
visually but does not remove the underlying code and the image will appear
in Reports generated from the JSON and in any new Reports Created from that
JSON. I'm sure other people are experiencing this an just not posting in
GitHub.
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKCLV75ALZKGSLEG2XWKPDZKQKGXAVCNFSM6AAAAABKJ2N3IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGU3DANBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
That you Fariba. Yes, Github is not exactly easy to use, took me a while to understand how to post, etc. I took my TT exam in 2019 and there was no ACRT for a while after that. I think it would be good to get issues addressed and also I wish there was a way to communicate with other ACRT users and TT process followers. There aren’t that many of us and there are the inevitable questions that arise when reviewing web pages. There are not any TT forums I’ve found for sharing thoughts and ideas. If you know of any let me know!
Thanks again and have a great holiday!
Rae
From: fareebs ***@***.***>
Sent: Wednesday, July 3, 2024 3:40 PM
To: Section508Coordinators/ACRT ***@***.***>
Cc: Benedetto, Luella (CTR) ***@***.***>; Comment ***@***.***>
Subject: Re: [Section508Coordinators/ACRT] Images not deleting (#25)
CAUTION: This email originated from outside of DHS. DO NOT click links or open attachments unless you recognize and/or trust the sender. Contact your component SOC with questions or concerns.
People are often too busy, don't know they can post on Github, or just
workaround the issues. I think I'm the only one that reports these
problems. Nevertheless, I'm about to socialize TT and ACRT to over 400+
system owners and would really like them to not feel frustrated or
disappointed with all the issues. I forwarded a list from another colleague
to Cliff Soon - please coordinate with him to see all the known issues.
Thank you.
Best,
Fariba Beg
alternate email - ***@***.***<mailto:***@***.***>
mobile - 240-340-7353
On Wed, Jul 3, 2024 at 11:29 AM raebened2 ***@***.***<mailto:***@***.***>> wrote:
This is an ongoing issue. Clicking "Remove Image" removes the image
visually but does not remove the underlying code and the image will appear
in Reports generated from the JSON and in any new Reports Created from that
JSON. I'm sure other people are experiencing this an just not posting in
GitHub.
—
Reply to this email directly, view it on GitHub
<#25 (comment)><https://urldefense.us/v3/__https:/github.com/Section508Coordinators/ACRT/issues/25*issuecomment-2206560459*3E__;IyU!!BClRuOV5cvtbuNI!DDX1fxmJASt4QGS-4gGGz6_u400Xggxb0bCBXNfWkxzHoBelJMMnEdcrEhFv2V8sv5k86aX7hPdDPROgY_me1yE0lRLTPH73Nw$>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKCLV75ALZKGSLEG2XWKPDZKQKGXAVCNFSM6AAAAABKJ2N3IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGU3DANBVHE><https://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/APKCLV75ALZKGSLEG2XWKPDZKQKGXAVCNFSM6AAAAABKJ2N3IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGU3DANBVHE*3E__;JQ!!BClRuOV5cvtbuNI!DDX1fxmJASt4QGS-4gGGz6_u400Xggxb0bCBXNfWkxzHoBelJMMnEdcrEhFv2V8sv5k86aX7hPdDPROgY_me1yE0lRIRTGQFYw$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***<mailto:***@***.***>>
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https:/github.com/Section508Coordinators/ACRT/issues/25*issuecomment-2207061426__;Iw!!BClRuOV5cvtbuNI!DDX1fxmJASt4QGS-4gGGz6_u400Xggxb0bCBXNfWkxzHoBelJMMnEdcrEhFv2V8sv5k86aX7hPdDPROgY_me1yE0lRL-AFIjUg$>, or unsubscribe<https://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BJP2HYLN34S4XF33VSP7J7DZKRHQDAVCNFSM6AAAAABKJ2N3IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGA3DCNBSGY__;!!BClRuOV5cvtbuNI!DDX1fxmJASt4QGS-4gGGz6_u400Xggxb0bCBXNfWkxzHoBelJMMnEdcrEhFv2V8sv5k86aX7hPdDPROgY_me1yE0lRIp1FEz8A$>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Hi, when we edit an existing JSON report and change a failure from "Fail" to "Pass", remove the image, it still generates the image in the HTML report. How do we bypass this? Are we missing a step or is this something with the code? Please contact me at fariba.beg.ctr@mail.mil. Thank you.
The text was updated successfully, but these errors were encountered: