Included warning TreeSHAP background dataset size. #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=======================================
Coverage 80.55% 80.55%
=======================================
Files 105 105
Lines 11790 11794 +4
=======================================
+ Hits 9497 9501 +4
Misses 2293 2293
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #704. It warns the user that TreeShap supports only up to 100 (
TREE_SHAP_BACKGROUND_SUPPORTED_SIZE) samples in the background dataset. Note that there is a logic related to the summarisation of the background dataset which uses 1000(TREE_SHAP_BACKGROUND_WARNING_THRESHOLD) as (warning) threshold. Although theTREE_SHAP_BACKGROUND_WARNING_THRESHOLD > TREE_SHAP_BACKGROUND_SUPPORTED_SIZEwhich might be contradictory, we leave that logic untouched. This approach has at least two benefits:shapwhich fixes the issue is used before we update our dependencies inalibi(i.e. just ignore the warning)