Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Included Tensorflow model tests for CFRL. #793

Merged

Conversation

RobertSamoilescu
Copy link
Collaborator

This PR includes the Tensorflow model test for CFRL to increase coverage (i.e. addresses #760)

@RobertSamoilescu RobertSamoilescu force-pushed the fix/models-tensorflow-coverage branch from f985421 to 7df7b9d Compare September 28, 2022 12:19
@RobertSamoilescu RobertSamoilescu force-pushed the fix/models-tensorflow-coverage branch from 7df7b9d to df62c42 Compare September 28, 2022 12:25
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #793 (4338182) into master (3b6756e) will increase coverage by 0.80%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   75.72%   76.53%   +0.80%     
==========================================
  Files          72       72              
  Lines        8224     8224              
==========================================
+ Hits         6228     6294      +66     
+ Misses       1996     1930      -66     
Flag Coverage Δ
macos-latest-3.10.6 76.41% <ø> (+0.80%) ⬆️
ubuntu-latest-3.10.6 ?
ubuntu-latest-3.7 76.34% <ø> (+0.90%) ⬆️
ubuntu-latest-3.8 76.38% <ø> (+0.80%) ⬆️
ubuntu-latest-3.9 76.28% <ø> (+0.70%) ⬆️
windows-latest-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi/models/tensorflow/autoencoder.py 100.00% <0.00%> (+43.47%) ⬆️
alibi/models/tensorflow/cfrl_models.py 100.00% <0.00%> (+75.67%) ⬆️

@RobertSamoilescu RobertSamoilescu force-pushed the fix/models-tensorflow-coverage branch from 93a7717 to 4338182 Compare September 28, 2022 13:40
Copy link
Contributor

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce, thanks!

@jklaise jklaise merged commit fa034a2 into SeldonIO:master Oct 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants