Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed Anchor Text LM AR input_ids updates. #895

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

RobertSamoilescu
Copy link
Collaborator

This PR fixes an issue with the AnchorText with LM sampler AR mode which was not updating the input_ids tensor as token replacements were generating for the masked tokens.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would just remove the warning from the notebook.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #895 (a9ef0e0) into master (71027cb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
- Coverage   85.34%   85.33%   -0.01%     
==========================================
  Files          74       74              
  Lines        8801     8802       +1     
==========================================
  Hits         7511     7511              
- Misses       1290     1291       +1     
Flag Coverage Δ
macos-latest-3.10 85.19% <0.00%> (-0.11%) ⬇️
ubuntu-latest-3.10 85.28% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.7 85.19% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 85.22% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 85.22% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 82.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explainers/anchors/language_model_text_sampler.py 78.36% <0.00%> (-0.47%) ⬇️

@jklaise jklaise merged commit c7f2c05 into SeldonIO:master Mar 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants