Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[java] Remove browserVersion from options in SM Java wrapper (fix #12633) #12639

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[java] Remove browserVersion from options in SM Java wrapper (fix #12633) #12639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions java/src/org/openqa/selenium/manager/SeleniumManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.openqa.selenium.Beta;
import org.openqa.selenium.Capabilities;
import org.openqa.selenium.MutableCapabilities;
import org.openqa.selenium.Platform;
import org.openqa.selenium.Proxy;
import org.openqa.selenium.WebDriverException;
Expand Down Expand Up @@ -256,6 +258,7 @@ public Result getDriverPath(Capabilities options, boolean offline) {
if (!options.getBrowserVersion().isEmpty()) {
arguments.add("--browser-version");
arguments.add(options.getBrowserVersion());
((MutableCapabilities) options).setCapability("browserVersion", Optional.empty());
}

String browserBinary = getBrowserBinary(options);
Expand Down
Loading