Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[rb] Disable provide response test for Firefox #15295

Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ module WebDriver
end

describe '#scroll_by' do
it 'scrolls by given amount' do
it 'scrolls by given amount', except: {browser: :firefox, reason: 'returns false on firefox'} do
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
footer = driver.find_element(tag_name: 'footer')
delta_y = footer.rect.y.round
Expand Down
3 changes: 2 additions & 1 deletion rb/spec/integration/selenium/webdriver/bidi/network_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ class BiDi
end
end

it 'provides response' do
it 'provides response', except: { browser: :firefox,
reason: 'https://github.com/w3c/webdriver-bidi/issues/747' } do
reset_driver!(web_socket_url: true) do |driver|
network = described_class.new(driver.bidi)
network.add_intercept(phases: [described_class::PHASES[:response_started]])
Expand Down
10 changes: 6 additions & 4 deletions rb/spec/integration/selenium/webdriver/network_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@

module Selenium
module WebDriver
describe Network, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
only: {browser: %i[chrome edge firefox]} do
describe Network, exclusive: { bidi: true, reason: 'only executed when bidi is enabled' },
only: { browser: %i[chrome edge firefox] } do
let(:username) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.first }
let(:password) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.last }

Expand Down Expand Up @@ -160,7 +160,7 @@ module WebDriver
sameSite: 'Strict',
expiry: 1234
})
request.body = ({test: 'example'})
request.body = ({ test: 'example' })
request.continue
end
driver.navigate.to url_for('formPage.html')
Expand Down Expand Up @@ -262,7 +262,9 @@ module WebDriver
end
end

it 'adds a response handler that provides a response' do
it 'adds a response handler that provides a response',
except: { browser: :firefox,
reason: 'https://github.com/w3c/webdriver-bidi/issues/747' } do
reset_driver!(web_socket_url: true) do |driver|
network = described_class.new(driver)
network.add_response_handler do |response|
Expand Down