dependency check #25
Merged
dependency check #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichumuh
requested changes
Feb 26, 2019
dependencies.txt
Outdated
| qpoases==3.1.0 | ||
| giskard_msgs==0.1.0 | ||
| py_trees_ros==0.5.14 | ||
| py_trees==0.6.1 |
There was a problem hiding this comment.
I think this is a bit too restrictive. Can you do an upper and lower limit, something like 1.15.4 < numpy < 2.0? Some libraries push the first number only if they have breaking api changes. So a restriction like my example would be nice for all libs. Only for pybullet we should require a specific version, its also missing in this list.
src/giskardpy/utils.py
Outdated
| elif version_m[i] > version_d[i]: | ||
| print("found ROS package " + l[0][:-1] + "==" + str( | ||
| m.version) + " but " + name + " is required") |
There was a problem hiding this comment.
Please always use single quotes for strings, so that it's consistent with the rest of my code. And use '{}'.format(), to build strings.
src/giskardpy/utils.py
Outdated
| r = rospkg.RosPack() | ||
| try: | ||
| l = name.split('=') |
There was a problem hiding this comment.
Please use more descriptive variable names.
|
thx |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.