WIP: smRadioGroup and smRadioButton directives

[m0t0r]

Status: Work in progress
Based on #5

[m0t0r]

@caitp how does it look like so far ?

[caitp]

nit: should probably just make a helper function that does this

[m0t0r]

Where that helper function should be placed ?

[m0t0r]

@caitp, can you make a refresh in here please. What sort of helper function did you mean ? and also my initial question is still needs an answer :)

[caitp]

something like

function createRadioGroup(model, valuesAndLabels) {
  var template = '<sm-radio-group ng-model="' + model + '">' +
                 Object.getOwnPropertyNames(valuesAndLabels).map(function(value) {
                   var label = valuesAndLabels[value];
                   return '<sm-radio-button value="' + value + '">' + label + '</sm-radio-button>';
                 }).join("") + '</sm-radio-group>';
  element = $compile(template)($scope);
  // and whatever other setup you want to do
}

var kBaseKeys = Object.freeze({
  1: "One",
  2: "Two",
  3: "Three"
});

createRadioGroup("value",  kBaseKeys);

or something like that --- but it's your call man, it can just be a bit nicer to write tests without having to do lots of string concatenation and stuff

[m0t0r]

Looks nice, thank you.

[caitp]

actually, Object.keys is probably a better option, so you avoid engine stuff creeping in... might be better to use arrays to keep the order. anyway, do whatever works for you

[caitp]

the implementation basically looks okay to me, room for a few improvements, but mostly just nits

[caitp]

you can certainly merge this whenever you like, if you want to, adding helpers to the test suite to make it a bit easier to write tests is something you can do later (or not), if you like.

LGTM

[m0t0r]

I haven't added any accessibility stuff, that matters as I understood from the first directives, will add that part also and then good to go for merge 👍

[caitp]

+1

[m0t0r]

@caitp Can we land this and then improve the accessibility stuff ? I am finishing one project and hope to get more free time.

[caitp]

yes, lgtm, merge at will =)