-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(Ref): use component from Stardust UI #3774
Conversation
9ca1fa5
to
8defc07
Compare
8defc07
to
be751f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3774 +/- ##
==========================================
- Coverage 99.84% 99.83% -0.01%
==========================================
Files 175 172 -3
Lines 3125 3101 -24
==========================================
- Hits 3120 3096 -24
Misses 5 5
Continue to review full report at Codecov.
|
@layershifter Sorry for mention you here, What does it mean "convergence effort between Semantic UI React & Stardust UI."? StardustUI provides the JS/component part and SemanticUI the style/look and feel part? It is to make the core lightweight? |
Stardust UI was forked from SUIR, in the current state components there have a bit different API, design and ideas. To clarify, Stardust is more accessible, uses CSS-in-JS for styles and has some API changes in shorthands that were implemented based on consumers feedback and our experience. However, there are also caveats, it's less stable, supports less features and don't offer other themes than Teams. However, there is a lot of things that can and should be shared. At least to simplify maintenance, first it's a
In the end we will probably end with this, but it's a long ride 🚗 Currently, just converge utils. |
Sounds really good, specially the CSSinJS use, overriding SUI specificity is hard. |
This PR is a part of convergence effort between Semantic UI React & Stardust UI.
🔮
Ref
component is reexported from Stardust UIStardust UI has the same
Ref
component as Semantic UI. To simplify maintenance we will supportRef
component only under Stardust.Docs for this component will be also removed from Semantic UI, but still will be available under Stardust: https://stardust-ui.github.io/react/components/ref/definition
These changes should not affect you as SUIR user, however.
😨 Possible breaking changes
Things below were never advertised as public API, but should be mentioned:
StrictRefProps
,RefFindNodeProps
,StrictRefFindNodeProps
,RefForwardProps
,StrictRefForwardProps
are no longer exported.RefFindNode
&RefForward
components are no longer exported.Also bumps
react-popper
to latest.