Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix error by search methode and add Readme #4194

Closed
wants to merge 1 commit into from

Conversation

ivankenou
Copy link

fixes #4065

i try to fix these issues by searc dropdown

@welcome
Copy link

welcome bot commented Apr 18, 2021

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@ff70355). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4194   +/-   ##
=========================================
  Coverage          ?   99.75%           
=========================================
  Files             ?      180           
  Lines             ?     3241           
  Branches          ?        0           
=========================================
  Hits              ?     3233           
  Misses            ?        8           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff70355...ffcd0b4. Read the comment docs.

@ivankenou
Copy link
Author

I misunderstood what it was about
I think I'll start again

@ivankenou ivankenou closed this May 4, 2021
@ivankenou ivankenou deleted the 4065 branch May 4, 2021 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown with inline+search looks very broken with no results found
2 participants