Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

replace loadsh invoke with optional chaining #4428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thing18
Copy link

@thing18 thing18 commented May 13, 2023

No description provided.

@welcome
Copy link

welcome bot commented May 13, 2023

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

@thing18 you need to remove some of Lodash imports as in some files it was a single usage. Run yarn lint locally to detect failures.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants