Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Menu] Search should not cut off input text #5281

Closed
koddsson opened this issue Apr 17, 2017 · 4 comments
Closed

[Menu] Search should not cut off input text #5281

koddsson opened this issue Apr 17, 2017 · 4 comments
Milestone

Comments

@koddsson
Copy link

Here's a fiddle demonstrating the issue. I noticed this first in the semantic docs when there's a search input in the menu component so I assume that it's pretty easy to reproduce. The fiddle is basically a copy of the code in the docs.

Here's a screenshot of what I'm getting in case the issue is not re-producable:

image

This seems to be because a border-radius on the input, since only the first letter has the cutoff:

image

Info

  • Browser: Google Chrome Version 57.0.2987.133 (64-bit)
  • OS: MacOS Sierra 10.12.4
koddsson pushed a commit to koddsson/Semantic-UI that referenced this issue Apr 17, 2017
The `border-radius` property in the search input was cutting of parts of
the first letter in the prompt.

The prompt class name seems to be needed from the example in the docs[1]
so resetting the `border-radius` for a search prompt when it's in a menu
component seems like the most straight-forward solution.

[1]: https://semantic-ui.com/collections/menu.html#search

Closes Semantic-Org#5281
@awgv awgv added this to the Needs Milestone milestone Apr 17, 2017
@awgv
Copy link
Member

awgv commented Apr 17, 2017

Thanks. I wonder why it can’t be reproduced on the menu component’s documentation page, the markup seems to be identical; the clipping has always been there, just not that severe.

@koddsson
Copy link
Author

Hmm, I'm able to reproduce it in the menu documentations page:

image

@jlukic jlukic modified the milestones: 2.2.11, Needs Milestone Apr 17, 2017
@jlukic
Copy link
Member

jlukic commented Apr 17, 2017

It does look like its cutoff by 1px on base em. Probably could be more/less noticable if base em was different as well.

@jlukic
Copy link
Member

jlukic commented Jul 2, 2017

Fixed in 2.1.11 thank you for your patience.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants