Fix ci

[paladox]

No description provided.

[paladox]

I dunno how to fix the rest of ci.

it's failing with:

There were 4 failures:

1) SIL\Tests\Category\LanguageFilterCategoryViewerTest::testAddSubcategoryForNoInterlanguageLinksLookup
Failed asserting that a NULL is not empty.

/var/www/html/extensions/SemanticInterlanguageLinks/tests/phpunit/Unit/Category/LanguageFilterCategoryViewerTest.php:143

2) SIL\Tests\InterlanguageLinksLookupTest::testRedirectTargetFor
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
     'mTitleValue' => null
     'mIsBigDeletion' => null
     'mIsValid' => true
-    'mInstanceCacheKey' => 'SIL\Tests\InterlanguageLinksL...getFor'
+    'mInstanceCacheKey' => null
     'deprecatedPublicProperties' => Array (...)
     'dynamicPropertiesAccessDeprecated' => false
 )

/var/www/html/extensions/SemanticInterlanguageLinks/tests/phpunit/Unit/InterlanguageLinksLookupTest.php:67

3) SIL\Tests\InterlanguageListParserFunctionTest::testParseForValidLanguageTargetLinks with data set #2 (array(Title Object (...)), '{{FakeTemplate|#=0|target-lin...简体）‎}}')
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '{{FakeTemplate|#=0|target-link=分类：汉字|lang-code=zh-Hans|lang-name=中文（简体）‎}}'
+    0 => '{{FakeTemplate|#=0|target-link=分类：汉字|lang-code=zh-Hans|lang-name=中文（简体）}}'
     'noparse' => false
     'isHTML' => false
 )

/var/www/html/extensions/SemanticInterlanguageLinks/tests/phpunit/Unit/InterlanguageListParserFunctionTest.php:105

4) SIL\Tests\InterlanguageListParserFunctionTest::testParseForValidLanguageTargetLinks with data set #3 (array(Title Object (...)), '{{FakeTemplate|#=0|target-lin...简体）‎}}')
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '{{FakeTemplate|#=0|target-link=:Category:汉字|lang-code=zh-Hans|lang-name=中文（简体）‎}}'
+    0 => '{{FakeTemplate|#=0|target-link=:Category:汉字|lang-code=zh-Hans|lang-name=中文（简体）}}'
     'noparse' => false
     'isHTML' => false
 )

/var/www/html/extensions/SemanticInterlanguageLinks/tests/phpunit/Unit/InterlanguageListParserFunctionTest.php:105

I spent ages looking and couldn't figure it out.

Any ideas?

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[paladox]

Marked MW 1.43 support as experimental.

SemanticInterlanguageLinks/tests/phpunit/Unit/InterwikiLanguageLinkFetcherTest.php

Line 82 in e81df34

public function testValidInterwikiLink() {

fails under MW 1.43. This I think is due to the behaviour change of

SemanticInterlanguageLinks/src/InterwikiLanguageLinkFetcher.php

Line 40 in e81df34

foreach ( $parserOutput->getLanguageLinks() as $languageLink ) {

in MW 1.43.

But I don't know how to fix that. So for now this pull is ok to merge as it adds support for MW 1.39-MW 1.42.