ID3v2: Handle genre IDs in TCON frames #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Nov 4, 2023
src/id3/v2/tag.rs
Outdated
| return None; | ||
| }; | ||
|
|
||
| let mut genres = genres.peekable(); |
There was a problem hiding this comment.
This should either always fail or always succeed.
Either use expect() at runtime or better require Peekable and implement it for GenreIter.
There was a problem hiding this comment.
I don't understand how this can fail? I'll try implementing Peekable for GenreIter though.
There was a problem hiding this comment.
From what I can gather directly implementing Peekable doesn't seem to be recommended and calling genres.peekable() should be fine unless I'm missing something.
|
Reworked the |
|
Yep, looks good to me. Thanks for working on this! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played around with this and came up with an implementation that returns an iterator and avoids allocation. It seemed appropriate to change the genre getter for the
Accessorimpl to use the new method so that numeric IDs will be translated and multiple values joined with '/' as perget_text. That's done as a separate commit in case it's a problem.One question is whether
get_textsandget_textshould behave the same asgenresandgenrefor TCON frames? I think this could be done fairly cleanly by reworkingGenresIterinto a more genericMultiValueIterand using it inget_texts. I can add another commit to this PR to address that if necessary.closes #281