Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix unwanted nametags paint tooltip #414

Merged
merged 18 commits into from
Apr 19, 2023

Conversation

MatinAniss
Copy link
Collaborator

@MatinAniss MatinAniss commented Mar 29, 2023

Added check that removes the nametag paint name tooltip if nametag paints are disabled.

BUG screenshot:
Screenshot_4

FIXED screenshot:
Screenshot_5

Fixes #410

Copy link
Contributor

@Melonify Melonify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is the right way to do this, I think it would be preferable to instead not set paint when the setting is disabled.

@AnatoleAM AnatoleAM force-pushed the master branch 2 times, most recently from 1b53f72 to f6b0303 Compare April 12, 2023 23:56
@MatinAniss MatinAniss requested a review from Melonify April 15, 2023 23:09
Copy link
Contributor

@AnatoleAM AnatoleAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paint should simply not be set when the option is disabled, rather than adding this extra check in the template.

@MatinAniss
Copy link
Collaborator Author

ah, that is what you meant. I changed how name tags paints should be disabled overall which removes the old method which was commented to be replaced. This way the nametag paint and tooltip are disabled without extra checks like I did. :)

@MatinAniss MatinAniss requested a review from AnatoleAM April 18, 2023 01:35
@AnatoleAM AnatoleAM merged commit b84fe4f into SevenTV:master Apr 19, 2023
@MatinAniss MatinAniss deleted the fix-nametags-paints-tooltip branch April 19, 2023 22:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Nametag Paint-names shown always
3 participants