Add Ability to Hide Unwanted Page Elements

[ZemyCode]

Hide Elements Feature

This feature addition adds a new menu in the settings for hiding certain page elements based on requests from different issues.

This is what the new menu looks like:

Various settings added with false being default value for all of them:

Feedback will be wanted for the names and descriptions of the settings.

Also requesting feedback on the performance or code quality as I am not sure if calling "updateHiddenElements()" on every setting change is optimal.

Edited 4/27/2023: Removed "Home Page" feature for hiding Front Page Carousel due to being buggy, may look into this more in the future.

[Melonify]

Maybe hiding offline channels in the sidebar should be an option here as well.

Also I think the settings tab should be named something more generic, like Layout or something, or be a sub-section of Appearance -> Interface

[ZemyCode]

Maybe hiding offline channels in the sidebar should be an option here as well.

Also I think the settings tab should be named something more generic, like Layout or something, or be a sub-section of Appearance -> Interface

@Melonify I looked into making it a subsection of Appearance -> Interface but it does not seem a subsection of a subsection is supported in the code right now. I think there are too many "Hide" settings for all of them to just be a part of the "Interface" subsection, should I just go with the "Layout" idea?

Or should I make a subsection of Appearance called "Hide" or "Hide elements"? The issue with this one would be I feel like having subsections for "Hide" is important like the current subsections I already made called "Chat", "Side bar" etc. since it makes it easier for the user to find the specific element they want to hide.

[Melonify]

Maybe a full section is better, perhaps "Site Layout", is a better name than "Layout"

[AnatoleAM]

@ZemyCode any updates on this PR?

[ZemyCode]

@ZemyCode any updates on this PR?

@AnatoleAM I have been out of town and unable to work on this but can work on it soon. Iirc the last thing I have to do is edit how it appears in the menu and just test things a little more.

[ZemyCode]

@AnatoleAM I think this can be reviewed now, changed the menu from "Hide" to "Site Layout", removed the hide front page carousel since it was buggy and I may look into adding it in a future PR. Also included the "gift a sub" button in the "Hide Subscribe Button" setting.

[AnatoleAM]

Thanks for the contribution 🙂 drop your username if you'd like to receive the Contributor chat badge

[ZemyCode]

@AnatoleAM thanks! If anyone reports any bugs with this feature I will look into them. I have already received the contributor badge from the "copy" button addition 😄 .

[AnatoleAM]

Oh, right, I forgor 💀