-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: v4 - go small go home #130
base: main
Are you sure you want to change the base?
Conversation
crates/punktf-lib-gsgh/src/env.rs
Outdated
@@ -0,0 +1,81 @@ | |||
use std::{ | |||
collections::{btree_set, BTreeMap, BTreeSet, HashSet}, |
Check warning
Code scanning / clippy
unused imports: `HashSet`, `ops::Deref`
crates/punktf-lib-gsgh/src/env.rs
Outdated
@@ -0,0 +1,81 @@ | |||
use std::{ | |||
collections::{btree_set, BTreeMap, BTreeSet, HashSet}, | |||
ops::Deref, |
Check warning
Code scanning / clippy
unused imports: `HashSet`, `ops::Deref`
crates/punktf-lib-gsgh/src/env.rs
Outdated
} | ||
} | ||
|
||
return None; |
Check warning
Code scanning / clippy
unneeded `return` statement
crates/punktf-lib-gsgh/src/value.rs
Outdated
where | ||
E: de::Error, | ||
{ | ||
Ok(Value::Int(v as i64)) |
Check warning
Code scanning / clippy
casting to the same type is unnecessary (`i64` -> `i64`)
crates/punktf-lib-gsgh/src/value.rs
Outdated
where | ||
E: de::Error, | ||
{ | ||
Ok(Value::Float(v as f64)) |
Check warning
Code scanning / clippy
casting to the same type is unnecessary (`f64` -> `f64`)
Discussion here: #128